Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pkg.go.dev badge to readme #46

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

mkraft
Copy link
Contributor

@mkraft mkraft commented Oct 18, 2024

#14

Adds pkg.go.dev documentation badge to readme.

@philhassey
Copy link
Collaborator

Thanks for this, I'm unable to review today but I hope to have time later this week!

@philhassey
Copy link
Collaborator

@mkraft Can you add DCO signing to your commit?

Thanks!
-Phil

@philhassey
Copy link
Collaborator

@mkraft
Copy link
Contributor Author

mkraft commented Oct 26, 2024

@mkraft Can you add DCO signing to your commit?

Thanks! -Phil

Updated. Thanks Phil.

Copy link
Collaborator

@philhassey philhassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philhassey
Copy link
Collaborator

Thanks for the contribution 👍 I've wanted this for months!

@philhassey philhassey merged commit 9931d56 into cedar-policy:main Oct 28, 2024
3 checks passed
@mkraft mkraft deleted the go-pkg-badge branch October 29, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants